search

jupyter-widgets / team-compass

A repository for team meetings and org-wide organization things
3 stars 6 forks source link

Unify cookiecutters? #4

Open ianhi opened 3 years ago

ianhi commented 3 years ago

Problem

The js and ts cookiecutters can easily get out of sync, for example the js cookiecutter uses widgets.register while the ts cookiecutter does not. Looking through them there are several PRs that apply to one but not the other, even if the same changes would apply equally. For instance the cookiecutters ought to have the same packaging, so PRs such as https://github.com/jupyter-widgets/widget-cookiecutter/pull/87 will require duplicated effort.

Proposed Solution

Create a single cookiecutter that has an option to choose ts or js.

jtpio commented 3 years ago

Thanks @ianhi for opening this issue.

This also came up for the JupyterLab cookiecutters when updating the JS cookiecutter to the new distribution system: https://github.com/jupyterlab/extension-cookiecutter-js/pull/33#issuecomment-767648077

Now extension-cookiecutter-js and extension-cookiecutter-ts are very similar. It was briefly discussed in this lab dev meeting whether or not they should be a single cookiecutter: https://github.com/jupyterlab/team-compass/issues/117#issuecomment-768481391 (although there hasn't been any decision on this yet).