search

jupyter-widgets / tutorial

A tutorial for widgets
BSD 3-Clause "New" or "Revised" License
391 stars 160 forks source link

Remove vaex Notebook #82

Closed martinRenou closed 4 years ago

martinRenou commented 4 years ago

This Notebook relies on a huge dataset that we cannot put on the repository, so I thought it might be a good idea to remove it. Any thoughts?

maartenbreddels commented 4 years ago

Makes sense, we could also use the remote dataframe API, it would require an internet connection though. Let me know if you're interested.

martinRenou commented 4 years ago

We are trying to clean up the Notebooks directory a bit, so if we go using the remote dataframe API thing we might want to put the vaex Notebook under the extra_examples directory? https://github.com/jupyter-widgets/tutorial/tree/master/notebooks/extra_examples

mwcraig commented 4 years ago

We are trying to clean up the Notebooks directory a bit, so if we go using the remote dataframe API thing we might want to put the vaex Notebook under the extra_examples directory?

I think it would be good to include it in the extra_examples directory. It is an impressive package that widget folks should be aware exists, and I see the "extras" folder as that.

mwcraig commented 4 years ago

@martinRenou -- what do we need to do to wrap this up?

martinRenou commented 4 years ago

Maybe we can move this Notebook in the extra_examples directory and add a comment showing where to download the dataset?

mwcraig commented 4 years ago

OK, I'll open a PR to do that later today.

martinRenou commented 4 years ago

Done in #90