search

jupyter-widgets / widget-cookiecutter

A cookiecutter template for creating a custom Jupyter widget project.
BSD 3-Clause "New" or "Revised" License
258 stars 72 forks source link

Addressing issue where npm isn't found on windows #21

Closed gbivins closed 7 years ago

gbivins commented 7 years ago

This change adds 2 things

  1. Method to get a name for the npm command based on platform (windows vs others)
  2. Use the method to get the platform specific name for npm so that setup tools succeed

I tested on my generated widget code but I didn't see any other way to test this change.
If there is, I'd be more than happy to run them to verify the changes.

Fixes #20

jasongrout commented 7 years ago

Thanks!

gbivins commented 7 years ago

@jasongrout Just saw this! My first accepted PR on github outside of my own repos :smile:

jasongrout commented 7 years ago

Congratulations!