search

jupyter-widgets / widget-cookiecutter

A cookiecutter template for creating a custom Jupyter widget project.
BSD 3-Clause "New" or "Revised" License
258 stars 72 forks source link

JupyterLab extension files not bundled into pip package #58

Open mbektas opened 4 years ago

mbektas commented 4 years ago

we discovered this issue while working on documentation with @pbugnion. widget-cookiecutter is not including lab extension files into pip package unlike widget-ts-cookiecutter does in https://github.com/jupyter-widgets/widget-ts-cookiecutter/blob/master/%7B%7Bcookiecutter.github_project_name%7D%7D/setup.py#L49

martinRenou commented 4 years ago

I'd love to see this happen actually. This goes along with the discussion we had on ipywidgets https://github.com/jupyter-widgets/ipywidgets/issues/2806. I've made this update in ipyleaflet and ipympl very recently. But it would be super nice if all widgets libraries do that, it would simplify things.

I can come up with a PR.