example 'kilo' does not support special characters

[Ryder17z]

"Debug Assertion Failed" points to file "minkernel/crts/ucrt/appcrt/convert/istype.cpp" line 36 "Expression: c > = -1 && c < = 255"

Would be nice to have utf-8 support, or at least utilize the older windows component for supporting non-english characters like 'å'

[flagarde]

@Ryder17z I agree this is a problem I'm aware of. I worked a bit on this but still not PR for now. I imagine example are here to show what the library can do and to trigger such problem and propose some changes to the library to fix them.

[certik]

I see. The other examples support utf8, but not kilo. We'll have to fix it. Thanks @flagarde for working on it.

[flagarde]

@Ryder17z Could you give me more informations : 1) which line create the crash ? 2) Which text are you writing ? 3) You open a file or write it ?

I guess you are using window$ ?

[Ryder17z]

No file open, I just hit 'å' by accident. The issue is on win10, yes. The error message is quoted above, with a supposed location of the issue

On Tue, 9 May 2023, 11:38 flagarde, @.***> wrote:

@Ryder17z https://github.com/Ryder17z Could you give me more informations :

1. which line create the crash ?
2. Which text are you writing ?
3. You open a file or write it ?

I guess you are using window$ ?

— Reply to this email directly, view it on GitHub https://github.com/jupyter-xeus/cpp-terminal/issues/246#issuecomment-1539681858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPIOPYSXYVN64JVYLGNG3DXFIGCLANCNFSM6AAAAAAXZWELCE . You are receiving this because you were mentioned.Message ID: @.***>

[flagarde]

@Ryder17z By the way, are you using the tag 1.0.0 or the upstream version ?

[Ryder17z]

just whatever is on the master branch

[flagarde]

Stange this is encoded by 2 bits so it should be exclude from key value for now.. I will investigate