search

jupyter-xeus / cpp-terminal

C++ library for writing multiplatform terminal applications
https://jupyter-xeus.github.io/cpp-terminal/
Other
522 stars 55 forks source link

added new styles #258

Closed TobiasWallner closed 1 year ago

TobiasWallner commented 1 year ago

I added a lot of new style settings in the enum found in style.hpp. I tried to add all releveant ones and added comments about their behaviour and implementation support.

flagarde commented 1 year ago

@TobiasWallner Nice, it's nice to have more feature like this :). Could you do a program to show all the diferents style. It could be use to check each terminal

TobiasWallner commented 1 year ago

Yes I may do that. I started this because I wanted to have different cursor styles, so I will write something small to display all of them. Where should I put it? Should I write one in the examples folder?

flagarde commented 1 year ago

@TobiasWallner Yes I think in the examples fllder it would be nice

TobiasWallner commented 1 year ago

@flagarde May need help here. There is one failing test: "docs / 📚 Docs (pull_request)". I am not sure I think this already an open Issue, and you all are waiting for that to be merged, correct? Otherwise I need help on what to do to make this pass.

flagarde commented 1 year ago

@TobiasWallner I think this failing has been solved butbnotbin your PR we should not care about it

TobiasWallner commented 1 year ago

@flagarde Should I do or fix anything or can you do it. Or do you have any suggestions on how I can fix that?

flagarde commented 1 year ago

For me it looks fine, but I have been given with merge right very recently and I would like to have other people giving the green light. I'm mainly do project as only user so I fear to be a "deseperado merger". Maybe we could move to a Camel case ? (For me full uppercase is for macros to emphasis they are EVIL!) but again this should be maybe discuss with the original developers :)

flagarde commented 1 year ago

For the docs problem it's a doxygen problem... I have done a PR and issue report on the doxygen project. Maybe I can disable pdf generation for now.