search

jupyter-xeus / cpp-terminal

C++ library for writing multiplatform terminal applications
https://jupyter-xeus.github.io/cpp-terminal/
Other
490 stars 53 forks source link

Thread #284

Closed flagarde closed 11 months ago

flagarde commented 1 year ago

This is an other PR for input. @TobiasWallner I think this should improve performances.

TobiasWallner commented 1 year ago

I am currently in my hollidays, will have a look in 1 or 2 weeks.

Always nice to hear from your advancements.

flagarde commented 1 year ago

Before merging other PR I would like to merge this one as it is a really big change in the way cpp-terminal is processing the events. I hope it will solve some problems. Have you tried it with Lime ?

For example before using windows10 in virtualbox I was able to merge two keys typing very fast (just dumb typing), but I think this would happen too is the screen you wanted to print was hard to process so I think to have a thread dedicated to key press handling is the way to go + the thread is paused so it should consume less cpu. Only macos has the old behaviour because it seems not possible to do what I did in linux on a tty with macos :(

flagarde commented 1 year ago

I found some strane bugs on macos so I need moe time to fix

flagarde commented 12 months ago

@TobiasWallner @certik I'm more confident now with this PR, I have cleaned many things and added workaround for the strange bugs in macos. I have try with Lime but maybe you could have a try yourself because you knoe it better than me ^^. Still maybe some cleaning but I think it is clean anough to be merged