search

jupyter-xeus / xeus-cling

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
3.08k stars 297 forks source link

Fix options passed to the linker #467

Closed Hind-M closed 1 year ago

Hind-M commented 1 year ago

TODO Merge with main and check help after merging #465

JohanMabille commented 1 year ago

@Hind-M Can you rebase this one on main and force push after checking the help of magics please?

Hind-M commented 1 year ago

@Hind-M Can you rebase this one on main and force push after checking the help of magics please?

Done.

ghost commented 12 months ago

This PR breaks optional linker arguments. Only -fsanitize and -g are supported in v0.15 but v0.14 supports custom arguments like -l. Is this intentional? https://github.com/jupyter-xeus/xeus-cling/issues/477

JohanMabille commented 12 months ago

This is not intentional, it is a regression. We are a bit swamped at the moment, so a PR to fix it would be much appreciated.