search

jupyter-xeus / xeus-cling

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
3.02k stars 292 forks source link

Make xcpp*/kernel.json.in subsitution more portable #469

Closed serge-sans-paille closed 1 year ago

serge-sans-paille commented 1 year ago

According to https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

CMAKE_INSTALL_BINDIR can be either absolute or relative. Make sure we use the absolute value through CMAKE_INSTALL_FULL_BINDIR.

serge-sans-paille commented 1 year ago

this is a wip, I still need to sort out a few thing, please wait before considering reviewing this PR

serge-sans-paille commented 1 year ago

no longer a wip, feel free to review :-)

SylvainCorlay commented 1 year ago

I can't find a reference to CMAKE_INSTALL_FULL_BINDIR in the cmake documentation!

JohanMabille commented 1 year ago

here you have documentation for the generic CMAKE_INSTALL_FULL_<dir>.

SylvainCorlay commented 1 year ago

here you have documentation for the generic CMAKE_INSTALL_FULL_<dir>.

Great, then we should go ahead and make the fix in all xeus-based kernels.