search

jupyter-xeus / xeus-javascript

A JavaScript kernel for JupyterLite, powered by Xeus
https://jupyter-xeus.github.io/xeus-javascript/lab/index.html?path=xeus-javascript.ipynb
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Fix the deploy step #2

Closed jtpio closed 9 months ago

jtpio commented 10 months ago

As noticed in https://github.com/DerThorsten/xeus-javascript/pull/1#issuecomment-1900443240, the deploy step failed when opening a PR from a fork:

image

Maybe the workflow can be adjusted to put the if: condition earlier in the workflow definition.

DerThorsten commented 9 months ago

done in #9

jtpio commented 9 months ago

Thanks!