TODO: Add tests in test_xnelson_kernel.py

jupyter-xeus / xeus-nelson

Jupyter kernel for Nelson

GNU Lesser General Public License v3.0

7 stars 9 forks source link

TODO: Add tests in test_xnelson_kernel.py #19

Open anutosh491 opened 3 months ago

anutosh491 commented 3 months ago

The file says the following https://github.com/jupyter-xeus/xeus-nelson/blob/ac90e738d6609d75dd215c3709ab8506c807c0f1/test/test_xnelson_kernel.py#L9-L20

So currently no kernel tests are present I guess

Hind-M commented 3 months ago

It's actually just removing this and uncomment this IIRC. I will need to update my working environment to send a PR to fix this, but I guess it would be easier/faster if you think you can open a PR to replace the TestFake since you most probably have something up to date :)

anutosh491 commented 3 months ago

Raised a PR simply uncommenting the above as you mentioned but some tests fail (Need to look into it but I'm on vacation :| )

Hind-M commented 3 months ago

Hum 🤔 so maybe something is missing or they need to be adapted... But no worries, there is no rush, thanks!