search

jupyter-xeus / xeus-octave

Jupyter kernel for GNU Octave
https://xeus-octave.readthedocs.io/
GNU General Public License v3.0
57 stars 10 forks source link

Backport of the fixes/development in @rapgenic development branch (except xwidgets) #73

Closed rapgenic closed 1 year ago

rapgenic commented 1 year ago

Warning: depends on (or rather includes) #70

Hi, I've had a look at the development I'd done on the temp/33/template branch, and I tried to pick all the important changes in the code, excluding the xwidgets, which I'll have a look at in the next days (probably weekend).

I tried to split all the modifications in various commits, which however are not guaranteed to compile.

Every commit is logically independent and has a description of the modifications it includes to help you understand what's inside.

Please ask if you have any question. There is no hurry for a review, but I'd like to merge this eventually to avoid losing all the development I'd done before transferring the repo and to be able to go on experimenting with the xwidgets.

AntoinePrv commented 1 year ago

May I suggest taking the Flatten source tree commit in another PR? I looks like you'll need to rebase and this is not going to help with conflicts.

rapgenic commented 1 year ago

Hi @AntoinePrv, I've been using xeus-octave with this modifications for a few days and I found no problems with the backport.

If you're ok with it I'd like to remove the draft status from this PR.

Recently I've modified all the commits so that they can be built and run individually, so if you prefer I can open a PR for each commit for easier review.

In the meantime I've also backported the xwidgets implementation on top of this branch (and used it for a real world project to test it), but still haven't opened a PR for tidiness. If you're interested the branch is called widgets in my repo, otherwise I can open the PR.

AntoinePrv commented 1 year ago

Hi @rapgenic

That's great! Thanks!

Recently I've modified all the commits so that they can be built and run individually, so if you prefer I can open a PR for each commit for easier review.

If it not too cumbersome, separate PR will definitely make it easier to review.

In the meantime I've also backported the xwidgets implementation on top of this branch (and used it for a real world project to test it), but still haven't opened a PR for tidiness.

Great, I'm looking forward to see xwidgets in Xeus-Octave!