search

jupyter-xeus / xeus-octave

Jupyter kernel for GNU Octave
https://xeus-octave.readthedocs.io/
GNU General Public License v3.0
57 stars 10 forks source link

Fix memory error for PNG encoding #75

Closed AntoinePrv closed 1 year ago

AntoinePrv commented 1 year ago

This is on me for breaking something that was working :facepalm: Plots should be working on MacOS now.

AntoinePrv commented 1 year ago

Octave is still showing some warnings but seems irrelevant. @rapgenic it looks like we could silence those, right?

warning: opengl_renderer::render_text: support for rendering text (FreeType) was unavailable or disabled when Octave was built
warning: called from
    axes at line 107 column 8
    newplot at line 161 column 10
    surf at line 77 column 9
    sombrero at line 68 column 5
rapgenic commented 1 year ago

Well it's a bit strange if they weren't there before (I don't have them), I'll try pulling your changes to see if something changes.

rapgenic commented 1 year ago

I just built your changes and I do not see any warning... I actually don't know why it might be triggering them, possibly a missing library (e.g. freetype as reported)?

Anyways it was unlikely they were related so I think you can ignore them

AntoinePrv commented 1 year ago

Sorry, missing some context. They come on MacOS, when using the conda-forge Octave. I think it comes from there.