Backport [1/5]: IO system refactorings

jupyter-xeus / xeus-octave

Jupyter kernel for GNU Octave

https://xeus-octave.readthedocs.io/

GNU General Public License v3.0

57 stars 10 forks source link

Closed rapgenic closed 1 year ago

rapgenic commented 1 year ago

This is the first set of patches, mainly regarding input and output functions.

It can be resumed in the following points:

the io override/restore mechanism has been removed: the output must always be sent to jupyter even if a cell isn't executing (this is important for widgets).
a new function for registering symbols/functions in octave context has been added
input and output classes were split in two files and put in their own namespace for tidiness

AntoinePrv commented 1 year ago

Hi @rapgenic, sorry I missed that. Don't hesitate to ping me or request me as reviewer. I'll get on it.

rapgenic commented 1 year ago

Don't worry, probably my fault for not adding you as a reviewer.

Anyway it allowed me to test it for a longer time, which is a good thing

rapgenic commented 1 year ago

Sorry for letting this slide for so long, I had a very busy month...