jupyter-xeus / xeus-octave

Jupyter kernel for GNU Octave
https://xeus-octave.readthedocs.io/
GNU General Public License v3.0
57 stars 10 forks source link

Backport [2/5]: xinterpreter improvments #82

Closed rapgenic closed 1 year ago

rapgenic commented 1 year ago

This set of modifications backports some general improvements in the interpreter:

AntoinePrv commented 1 year ago

Thanks for making this changes!

rapgenic commented 1 year ago

@AntoinePrv sorry for pinging, I have fixed the xeus::register_interpreter as you suggested, and the fact that 5.3 protocol version comes from the cookiecutter is good enough for me to consider it "right".

There have been no other significant changes, so unless you need to review it again (just tell me in case, no need to do it in a short time :smile: ), I'll be merging this in the next few days.

Thanks!

rapgenic commented 1 year ago

Thank you for the changes, and don't worry, I didn't mean to put pressure to you...

I like better the get_protocol_version call, and to avoid doing the change again I'll leave the pointer instantiation as is, we can always change it later... it doesn't really make any difference at this stage.