Closed rapgenic closed 1 year ago
Thanks for making this changes!
@AntoinePrv sorry for pinging, I have fixed the xeus::register_interpreter
as you suggested, and the fact that 5.3
protocol version comes from the cookiecutter is good enough for me to consider it "right".
There have been no other significant changes, so unless you need to review it again (just tell me in case, no need to do it in a short time :smile: ), I'll be merging this in the next few days.
Thanks!
Thank you for the changes, and don't worry, I didn't mean to put pressure to you...
I like better the get_protocol_version
call, and to avoid doing the change again I'll leave the pointer instantiation as is, we can always change it later... it doesn't really make any difference at this stage.
This set of modifications backports some general improvements in the interpreter:
addpath.m
file but on a native C++ hook that is executed every time the path is changed and automatically fixes it as needed. (NB if you had already installed octave you'll need to remove the file in/usr/local/share/xeus-octave/addpath.m
)