jupyter-xeus / xeus-octave

Jupyter kernel for GNU Octave
https://xeus-octave.readthedocs.io/
GNU General Public License v3.0
57 stars 10 forks source link

Backport [3/5]: Move toolkits inside their own namespace #83

Closed rapgenic closed 1 year ago

rapgenic commented 1 year ago

Not much else to explain :)

rapgenic commented 1 year ago

I kinda agree with you, I do remember not liking it much too, but it helps readability here:

  // Register the graphics toolkits
  xeus_octave::tk::notebook::register_all(interpreter);
  xeus_octave::tk::plotly::register_all(interpreter);

Plus one of the next PR is about flattening the source tree, so I'd keep it like this if you're ok with it..