search

jupyter-xeus / xeus-octave

Jupyter kernel for GNU Octave
https://xeus-octave.readthedocs.io/
GNU General Public License v3.0
57 stars 10 forks source link

Split the notebook toolkit in two classes #92

Closed rapgenic closed 1 year ago

rapgenic commented 1 year ago

Into one generic class (glfw_graphics_toolkit) for implementing a glfw based toolkit, which the main toolkit (notebook_graphics_toolkit) inherits.

This is useful for implementing more than one toolkits that share the same rendering process (happening in the redraw_figure function of the base class) but a different way of sending the data to the frontend (through the send_figure function).

This is part of the work for the xwidgets integration, but it's independent enough to be considered on its own.

AntoinePrv commented 1 year ago

@rapgenic rebasing should fix the failing test.

rapgenic commented 1 year ago

I think we can wait for the next release before merging this