jupyter-xeus / xeus-python-wheel

Building a PyPI wheel for xeus-python
BSD 3-Clause "New" or "Revised" License
12 stars 13 forks source link

Disable cpack rules when building zeromq #82

Closed martinRenou closed 3 years ago

martinRenou commented 3 years ago

Follow up of https://github.com/conda-forge/xeus-python-static-feedstock/pull/11

wolfv commented 3 years ago

the appveyor build log seems to indicate that this is working?!

You could patch the current recipe with this change, and also add a test to the conda recipe that checks that the dlls are not there (e.g. if exists blabla.dll (exit 1) or so

martinRenou commented 3 years ago

Yes thanks! Yeah I was thinking of adding a patch in the recipe indeed, because the latest tag here maps to xeus-python's latest tag so we cannot really "release" it independently.

This makes me wonder if we should not have an independent version for the wheel. (EDIT: way no, bad idea. We want the PyPi version to be the right one)