Closed trungleduc closed 2 years ago
Could you change the following https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L248-L252 into:
FetchContent_Declare(
xeus-python
GIT_REPOSITORY https://github.com/trungleduc/xeus-python
GIT_TAG update-xpython-launcher
)
?
That way we can test it here
You're missing the configuration of the kernel spec for the raw mode https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L271-L274
Other than that, it seems to work fine!! (tried locally with the generated wheel)
You're missing the configuration of the kernel spec for the raw mode https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L271-L274
ah sorry, my mistake
Could you change the following https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L248-L252 into:
FetchContent_Declare( xeus-python GIT_REPOSITORY https://github.com/trungleduc/xeus-python GIT_TAG update-xpython-launcher )
?
That way we can test it here
I should revert to the original repo now?
Yes :) But you should change the xeus-python tag value to the new one 0.13.3
Triggering CI
Would be nice to add another simple test Notebook here https://github.com/jupyter-xeus/xeus-python-wheel/tree/master/test using the raw kernel
It's so good the new GHA, thank @martinRenou!
Yeah it's so much better ahah... It's also faster.
We still have the tests on xeus-python that are really not reliable. We should ditch jupyter_kernel_test
.
xpython_launcher
to pass all arguments to C++ side