jupyter-xeus / xeus-python-wheel

Building a PyPI wheel for xeus-python
BSD 3-Clause "New" or "Revised" License
12 stars 13 forks source link

Add raw kernel mode #85

Closed trungleduc closed 2 years ago

trungleduc commented 2 years ago
martinRenou commented 2 years ago

Could you change the following https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L248-L252 into:

FetchContent_Declare(
  xeus-python
  GIT_REPOSITORY https://github.com/trungleduc/xeus-python
  GIT_TAG update-xpython-launcher
)

?

That way we can test it here

martinRenou commented 2 years ago

You're missing the configuration of the kernel spec for the raw mode https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L271-L274

martinRenou commented 2 years ago

Other than that, it seems to work fine!! (tried locally with the generated wheel)

trungleduc commented 2 years ago

You're missing the configuration of the kernel spec for the raw mode https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L271-L274

ah sorry, my mistake

trungleduc commented 2 years ago

Could you change the following https://github.com/jupyter-xeus/xeus-python-wheel/blob/master/CMakeLists.txt#L248-L252 into:

FetchContent_Declare(
  xeus-python
  GIT_REPOSITORY https://github.com/trungleduc/xeus-python
  GIT_TAG update-xpython-launcher
)

?

That way we can test it here

I should revert to the original repo now?

martinRenou commented 2 years ago

Yes :) But you should change the xeus-python tag value to the new one 0.13.3

martinRenou commented 2 years ago

Triggering CI

martinRenou commented 2 years ago

Would be nice to add another simple test Notebook here https://github.com/jupyter-xeus/xeus-python-wheel/tree/master/test using the raw kernel

trungleduc commented 2 years ago

It's so good the new GHA, thank @martinRenou!

martinRenou commented 2 years ago

Yeah it's so much better ahah... It's also faster.

We still have the tests on xeus-python that are really not reliable. We should ditch jupyter_kernel_test.