Closed romainfrancois closed 9 months ago
Thanks @JohanMabille this is for now just tiptoe'ing.
But this makes me realise that we might here want to do things differently than IRkernel, so that we don't e.g. have to use the def _execute_code
workaround.
In short, we always send display_data
messages, and e.g. the code test suite expects execute_result
messages.
So, perhaps the execute()
R function should call publish_execution_result()
with the last result, i.e. "the result of the cell" and we display_data
messages are instead generated explicitly via the display()
function, perhaps also with the more R idiomatic View()
alias
That is still a lot of skips:
test_xr_kernel.py s.ss.s.sss.s.
But at least some are passing. I think I want to rework the display()
/ publish_execution_result()
situation, but that can happen in a separate PR.
Once you've implemented all the requests a kernel must support, a good test suite to run is Jupyter Kernel Test. You can find an example of how to do it here.