search

jupyter-xeus / xeus-r

Jupyter kernel for the R programming language
Other
42 stars 6 forks source link

Strip R_LDFLAGS strings in FindR.cmake #3

Closed SylvainCorlay closed 3 months ago

SylvainCorlay commented 1 year ago

Attempting to fix the Windows build.

SylvainCorlay commented 1 year ago

So we are now failing at the next step (configure passes, but build does not).

JohanMabille commented 1 year ago

It tries to link with the .dll files instead of the companions .lib files.

SylvainCorlay commented 1 year ago

Yeah, FindR returns the DLLs.

romainfrancois commented 1 year ago

Oh. So maybe FindR needs more logic to deal with windows. We can probably take some inspiration from how they do it for RInside with the windows specific Makefile.win file:

https://github.com/eddelbuettel/rinside/blob/master/inst/examples/standard/Makefile.win

romainfrancois commented 1 year ago

Moving the 🪡 a bit, now with this error : 

D:\a\xeus-r\xeus-r\src\xinterpreter.cpp(28): fatal error C1083: Cannot open include file: 'Rinterface.h': No such file or directory
romainfrancois commented 1 year ago

The Rinterface.h file is unix only, we're going to need to set the callbacks differently on windows. See https://vscode.dev/github/rstudio/rstudio/blob/main/src/cpp/r/session/REmbeddedWin32.cpp for how Rstudio does it.