search

jupyter-xeus / xeus-robot

Jupyter kernel for Robot Framework
BSD 3-Clause "New" or "Revised" License
31 stars 11 forks source link

Upgrade to xeus 3 #95

Closed SylvainCorlay closed 1 year ago

SylvainCorlay commented 1 year ago 
[100%] Linking CXX executable test_xeus_robot
/home/runner/micromamba-root/envs/xeus-robot/bin/../lib/gcc/x86_64-conda-linux-gnu/11.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: CMakeFiles/test_xeus_robot.dir/test_xrobot.cpp.o: in function `zmq::error_t::what() const':
main.cpp:(.text._ZNK3zmq7error_t4whatEv[_ZNK3zmq7error_t4whatEv]+0x9): undefined reference to `zmq_strerror'

It seems that would need to link the executable with Zeromq, although I presume this should be achieved transitively by have the target_link_libraries to xeus-zmq be PUBLIC. Thoughts @JohanMabille ?

JohanMabille commented 1 year ago

The issue is on the test executable, which is not linked against xeus-zmq, not the kernel itself (which seems to be built correctly).

EDIT: from the build logs, looks like the kernel is also failing to build/

JohanMabille commented 1 year ago

It seems that e're missing a find_dependency(xeus_zmq) in xeus-pythonConfig.cmake. A workaround would be to call find_package(xeus-zmq) in the CMakeLists.txt of xeus-robot.