search

jupyter-xeus / xeus-sql

Jupyter kernel for SQL databases
https://xeus-sql.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
165 stars 22 forks source link

Remove cleaning strings functions from xeus-sql to xvega-bindings #26

Open marimeireles opened 3 years ago

marimeireles commented 3 years ago

@wangfenjin introduced a new way to clean strings and it seems better to me.

However we shouldn't have this kind of common tool inside the kernel, it should be moved to the utils.hpp file on the xvega-bindings project.

It'd probably be nice to incorporate the same changes that took place here regarding cleaning strings on xeus-sql.