search

jupyter-xeus / xeus

Implementation of the Jupyter kernel protocol in C++
https://xeus.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
907 stars 83 forks source link

Replace function pointers #383

Closed IsabelParedes closed 8 months ago

IsabelParedes commented 8 months ago

Replacing the function pointers with std::functions to be able to pass lambda functions with captured values when creating the server or the debugger.

SylvainCorlay commented 8 months ago

LGTM!

SylvainCorlay commented 8 months ago

I think we should do a minor release with this one, and then a major with the passing of parent header as an argument.

cc @DerThorsten

JohanMabille commented 8 months ago

This one is ABI backward incompatible, meaning we need to rebuild all the kernels feedstocks, so I would be in favor of waiting for the parent header change and cut a major release (there is no hurry to release now).