search

jupyter-xeus / xeus

Implementation of the Jupyter kernel protocol in C++
https://xeus.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
907 stars 83 forks source link

fix argument order in publish_status #395

Closed DerThorsten closed 7 months ago

JohanMabille commented 7 months ago

Can you also set JSON_USE_IMPLICIT_CONVERSIONS to 0 in xeus.hpp? This would catch potential remaining similar issues, and would avod to get hit again in the future.

DerThorsten commented 7 months ago

superseded by #396

DerThorsten commented 7 months ago

JSON_USE_IMPLICIT_CONVERSIONS

Can you also set JSON_USE_IMPLICIT_CONVERSIONS to 0 in xeus.hpp? This would catch potential remaining similar issues, and would avod to get hit again in the future.

this gives a lot of warnings a la:

/Users/thorstenbeier/src/xeus/include/xeus/xeus.hpp:13:9: warning: 'JSON_USE_IMPLICIT_CONVERSIONS' macro redefined [-Wmacro-redefined]
   13 | #define JSON_USE_IMPLICIT_CONVERSIONS 0
      |         ^
/Users/thorstenbeier/micromamba/envs/xeus-wasm-dev/include/nlohmann/detail/macro_scope.hpp:467:13: note: previous definition is here
  467 |     #define JSON_USE_IMPLICIT_CONVERSIONS 1
JohanMabille commented 7 months ago

Ah, so it should probably be defined befor including nlohmann_json for the first time. Let's fix that in another PR.