search

jupyter-xeus / xeus

Implementation of the Jupyter kernel protocol in C++
https://xeus.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
902 stars 83 forks source link

Hide the implementation of comm_manager getters #400

Open JohanMabille opened 5 months ago

JohanMabille commented 5 months ago

The current implementation of xinterpreter::comm_manager is inlined in the header. It should (if possible) be moved to the source file.

JohanMabille commented 4 months ago

Actually, most of the implementation of the comms is also inlined, we should check that it doe snot break anything before hiding iit.