search

jupyter / atom-notebook

[Deprecated] Jupyter Notebook, but inside Atom.
MIT License
306 stars 48 forks source link

ViewRegistry.addViewProvider is deprecated. #48

Open shafreeck opened 8 years ago

shafreeck commented 8 years ago

atom.views.addViewProvider now takes 2 arguments: a model constructor and a createView function. See docs for details.

ViewRegistry.addViewProvider (/Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:52:18)
Object.activate (/Users/shafreeck/.atom/packages/jupyter-notebook/lib/main.js:51:16)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26)
srinathv commented 7 years ago

atom.views.addViewProvider now takes 2 arguments: a model constructor and a createView function. See docs for details. Report Issue ViewRegistry.addViewProvider - /Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:50:18 Object.activate - /Users/srinathv/.atom/packages/jupyter-notebook/lib/main.js:51:16 Package.activateNow - /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:191:19

- /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:164:32 Package.measure - /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:94:15 - /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:157:26
gnestor commented 7 years ago

This repo is not being actively maintained 🙁 In the meantime, I suggest that you look at hydrogen to run code inline in Atom's text editor, nteract (a new Jupyter notebook client built using Electron, React, Redux, RxJS), Jupyter Notebook, and JupyterLab.

Having said that, nteract is currently extracting its many components into separate packages which will allow them to be reused and assembled to create new apps. When I have the time, I would like to use them to completely refactor this project.

JHonaker commented 7 years ago

This is fixed by pull request #66

BenjaminHCCarr commented 7 years ago

Can we get this pushed to the apm network? I am on jupyter-notebook v0.0.9 with no updates available through atom or apm and still getting this error.

gnestor commented 7 years ago

@JHonaker Thanks!

gnestor commented 7 years ago

@BenjaminHCCarr It's currently listed on apm: https://atom.io/packages/jupyter-notebook

However, this project is not being actively maintained, but we're looking for help!

BenjaminHCCarr commented 7 years ago

I meant the jupyter/atom-notebook#66 fix.

I know it's not active, but to make it work in the atom repo would be great.

gnestor commented 7 years ago

Oh ok, v0.0.10 is published to apm 👍