Open arnavs opened 5 years ago
It looks like these issues have persisted for years. If this package is no longer being maintained, please remove it from the Atom listing of registered packages.
I struggled past this one bug and it wasn't worth it. Even after I got this package to "install" and "run", it didn't work. That is to say, the jupyter notebooks were unreadable within atom, with lines of code somehow divided up horizontally into table cells.
To get gyp working, I first struggled with updating node, and then with updating the gyp version used within npm (ie, https://github.com/nodejs/node-gyp/wiki/Updating-npm%27s-bundled-node-gyp because gyp finally fixed this bug per https://bugs.chromium.org/p/gyp/issues/detail?id=36&can=2&start=0&num=100&q=&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary&groupby=&sort= ), but when none of that worked, I eventually just set node's python executable with node-gyp --python /usr/local/bin/python2
.
Then, after this installed, I got a stale bug https://github.com/jupyter/atom-notebook/pull/68 which I fixed, and it ran. But still it didn't work, with evidence of multiple bugs still unfixed. So, sayonara.
@jamesonquinn looks like your commit was merged into master but now when I check in main.js in master it still has that extra curly bracket... even if that is corrected, there are other issues