jupyter / dashboards

[RETIRED] See Voilà as a supported replacement
https://github.com/voila-dashboards
Other
984 stars 210 forks source link

CLI quick-setup incompatibility with notebook 5.0 #289

Closed parente closed 7 years ago

parente commented 7 years ago

The BaseNBExtensionApp class is gone so the check if we're in >=4.2 fails here: https://github.com/jupyter/dashboards/blob/master/jupyter_dashboards/extensionapp.py#L12. Probably need to use notebook.extensions.BaseExtensionApp instead. That or remove the quick-setup convenience step and have people write out the install/enable/disable/uninstall manually.

https://github.com/jupyter/notebook/blob/master/notebook/extensions.py#L52

Ref: https://github.com/jupyter/notebook/issues/2150