jupyter / dashboards

[RETIRED] See Voilà as a supported replacement
https://github.com/voila-dashboards
Other
984 stars 211 forks source link

Fix #289: Notebook 5.0 compatibility #290

Closed parente closed 7 years ago

parente commented 7 years ago
parente commented 7 years ago

@DTAIEB, @jhpedemonte, @dalogsdon care to give this a look before I pull the trigger? It's all dev setup / install cleanup.

jhpedemonte commented 7 years ago

Any idea what travis failure is about (for last commit)?

parente commented 7 years ago

I can't get the travis log to load at the moment. Seems have gone haywire since the S3 outage yesterday.

jhpedemonte commented 7 years ago

I get same error as in travis. When running make env, I get this:

source activate dashboards && \
        pip install -r requirements-doc.txt && \
        npm install && \
        npm run bower && \
        pip install -e . && \
        jupyter dashboards quick-setup --sys-prefix &&
/bin/bash: -c: line 1: syntax error: unexpected end of file
jhpedemonte commented 7 years ago

Working for the most part, except it can't find declarative widgets. Should that be added to one of the requirements files?

parente commented 7 years ago

Added decl widgets but it's currently busted on install with matplotlib 2.0. Opened an issue about it on the widget repo.

I think I addressed all the issues noted here. Going to merge this in prep for 5.0.