Filter 'code' prop on 'execute_input' replies to client

jupyter / dashboards_server

[RETIRED] Server that runs and renders Jupyter notebooks as interactive dashboards

Other

181 stars 48 forks source link

Filter 'code' prop on 'execute_input' replies to client #219

Closed jhpedemonte closed 8 years ago

jhpedemonte commented 8 years ago

Fixes #217

parente commented 8 years ago

Code looks fine to me. I like that we have a consistent way to process any type of client or kernel originating message now.

I'll put it through the paces a bit today before merging.

parente commented 8 years ago

Everything I tried worked. I inspected the WS messages and saw no code. I looked at the message spec some more and found a few places where we might still have security holes. Will document those in #196 and we'll handle separately. For now, this one LGTM.