search

jupyter / dashboards_server

[RETIRED] Server that runs and renders Jupyter notebooks as interactive dashboards
Other
181 stars 48 forks source link

Updates Jupyter dependencies to use 'jupyterlab' module #261

Closed jhpedemonte closed 8 years ago

jhpedemonte commented 8 years ago

Updates to use latest output-area APIs

Fixes #259

jhpedemonte commented 8 years ago

This works for most of our test/demo notebooks. However, some ipywidgets and declwidgets have comm errors. Not sure why.

jhpedemonte commented 8 years ago

@blink1073 @jasongrout: I'm updating to use jupyterlab module. As you can see in changelog, I had to also make edits due to API changes around OutputAreaModel, OutputAreaWidget and RenderMime. Do these changes seem correct?

Most of our test notebooks are working, except I'm now seeing comm errors where I didn't previously (when using older jupyter-js-ui and jupyter-js-notebook). Any idea what changed to now cause these errors?

blink1073 commented 8 years ago

Those changes seem sensible to me. Can you give the actual comm errors?

jhpedemonte commented 8 years ago

@blink1073 Thanks for the quick review. The comm errors were actually a red herring -- turned out to be another required API change in our code.

Some declarative widgets are still broken. Getting the error Uncaught (in promise) Error: Model not ready, cannot send message for taxi demo.

blink1073 commented 8 years ago

I don't think that message is coming from jupyterlab or jupyter-js-services, but a word search in the ipywidgets repo did not net anything either.

jhpedemonte commented 8 years ago

No, that error message is from Declarative Widgets, just not sure why. @lbustelo @deedubbu

parente commented 8 years ago

@jhpedemonte Incompatibility between decl widgets 0.6.x and the new ipywidgets 5.2.2?

jhpedemonte commented 8 years ago

Rebased to latest master, which includes fix for taxi_demo_grid notebook. Not seeing any further issues on test/demo notebooks.

parente commented 8 years ago

w00t! I'll give it a shot here and merge if I can reproduce everything properly.

jhpedemonte commented 8 years ago

I'm also looking at updating services dependency.

parente commented 8 years ago

Tried every demo notebook. No surprises. :shipit:

blink1073 commented 8 years ago

:tada:

parente commented 8 years ago

Thanks for working through this @jhpedemonte (and the help @blink1073).