search

jupyter / dashboards_server

[RETIRED] Server that runs and renders Jupyter notebooks as interactive dashboards
Other
181 stars 48 forks source link

Allows read only NOTEBOOKS_DIR #268

Closed bodri5 closed 8 years ago

bodri5 commented 8 years ago

If the NOTEBOOKS_DIR is on a read only filesystem, the dashboard server gives the following error:

/usr/local/lib/node_modules/jupyter-dashboards-server/app/config.js:51 throw e; ^ Error: EROFS, read-only file system '/var/www/html/readonly/dashboards-public' at Object.fs.mkdirSync (fs.js:651:18) at Object. (/usr/local/lib/node_modules/jupyter-dashboards-server /app/config.js:48:12) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17) at require (module.js:380:17) at Object. (/usr/local/lib/node_modules/jupyter-dashboards-server /app/handlebars-helpers.js:6:14) at Module._compile (module.js:456:26)

This patch fixes this bug.

parente commented 8 years ago

If the notebook dir is on a read only file system and doesn't exist, will the dashboard server even be functional after this fix since the notebook directory wasn't created and there are no dashboards to serve?

bodri5 commented 8 years ago

The server may give a ENOENT error or start and fail later. However right now it does not start in my configuration.

bodri5 commented 8 years ago

I created a second version that addresses parente's concerns.