search

jupyter / dashboards_server

[RETIRED] Server that runs and renders Jupyter notebooks as interactive dashboards
Other
181 stars 48 forks source link

Busy / error improvements #270

Closed parente closed 8 years ago

parente commented 8 years ago

Show busy bar during kernel start. Show error indicator when kernel fails to start.

Fixes #269

parente commented 8 years ago

@jhpedemonte I think I addressed your comments in the way you were saying. I tested the error handling by killing the KG and watching for the indicator. I tried to test against the scala widgets notebook, but it seems to have stopped working since the PR this morning. (I'm guessing it's the external declarativewidgets.jar that's not getting pulled now for some external reason ...)

jhpedemonte commented 8 years ago

Just one minor nit. Otherwise, it's good to merge.

parente commented 8 years ago

Fixed nit. Merge away when green.