search

jupyter / dashboards_server

[RETIRED] Server that runs and renders Jupyter notebooks as interactive dashboards
Other
181 stars 48 forks source link

Support BASE_URL #291

Closed danielfrg closed 7 years ago

danielfrg commented 7 years ago

This is a possible fix for https://github.com/jupyter-incubator/dashboards_server/issues/260.

I am not a node dev so a probably some things could be improved, let me know and I can make changes. I have tested it a little bit and the only think that its not working is the font awesome assets are still trying to be located from /components/... but everything else looks fine.

jhpedemonte commented 7 years ago

I'll review today.

jhpedemonte commented 7 years ago

Closing in favor of #292.