Added the ability to call/reference functions within objects in Scala/R [See PR #436 first]

jupyter / declarativewidgets

[RETIRED] Jupyter Declarative Widget Extension

Other

120 stars 38 forks source link

Closed poplav closed 7 years ago

poplav commented 7 years ago

Follow on to the Python PR https://github.com/jupyter-incubator/declarativewidgets/pull/436. This adds the ability to call functions within objects in Scala/R as well.
Examples have been added to the R and Scala notebooks.
usage-docs/Calling-Functions.md have been updated
Usage Example
- val t = new Test() defined can then have the ref of the function be ref='t.math' where math is a function of the instance t.

poplav commented 7 years ago

@lbustelo ready for review see #436 too

lbustelo commented 7 years ago

Seems that references to top level functions is now broken in R

function_find

lbustelo commented 7 years ago

Scala works

poplav commented 7 years ago

@lbustelo System tests for python were added, python2 function signature issue fixed, R issue fixed. Should be ready to merge.

lbustelo commented 7 years ago

Looks good. Tried all the relevant notebooks and ran system tests locally.