search

jupyter / declarativewidgets

[RETIRED] Jupyter Declarative Widget Extension
http://jupyter.org/declarativewidgets/docs.html
Other
120 stars 38 forks source link

Enable DataFrame reference within objects in Python #531

Closed haobibo closed 7 years ago

haobibo commented 7 years ago

before: DataFrame variables can just be global variables. after: DataFrame can be a member of a class instance, like functions.

lbustelo commented 7 years ago

@haobibo I have not had a chance to take a look at why tests are failing now. It has something to do with Travis/Selenium/Chrome version.

haobibo commented 7 years ago

@lbustelo Yes, this step fails: wct elements/*/test "--local" "chrome". On my machine, this step outputs below errors: 

Installing and starting Selenium server for local browsers
Selenium server running on port 49506
Web server running on port 2000 and serving from D:\Dev\declarativewidgets
chrome 56                Beginning tests via http://localhost:2000/generated-index.html?cli_browser_id=0
chrome failed to maximize
404 GET /elements/webcomponentsjs/webcomponents-lite.js
404 GET /elements/test-fixture/test-fixture-mocha.js
404 GET /elements/polymer/polymer.html
404 GET /elements/test-fixture/test-fixture.html
404 GET /elements/test-fixture/test-fixture-mocha.js
404 GET /elements/test-fixture/test-fixture-mocha.js
chrome 56                Tests failed: Timed out
Test run ended in failure: Timed out

chrome 56 (error)

Error: Timed out

Seems to be some improper config of Selenium.

lbustelo commented 7 years ago

@haobibo I'm going to see if by shifting the tests over to firefox we at least get PRs moving. I'll let you know if it works so you can rebase.

poplav commented 7 years ago

Similarly to #436 and #480 (referencing functions within objects) we should remain feature parity across our supported languages. Also we need to update documentation, example notebooks, and tests. I can investigate more when I am back 12/12.

haobibo commented 7 years ago

@poplav thanks! actually i'm not quite familiar with scala.

poplav commented 7 years ago

@haobibo Thanks again for your contribution. We recently finished a revamp of our testing/build process at https://github.com/jupyter/declarativewidgets/pull/532. Can you rebase this with master and then we'll merge it!

haobibo commented 7 years ago

Hi @poplav , I noticed you are working on #535 (reference obj in DF in R/Scala). For this PR, I mistakenly deleted my branch, so it's hard for me to rebase now. Could you please add a commit to in branch poplav:df_in_obj to include changes in this PR, and I will close this PR?

poplav commented 7 years ago

@haobibo Thanks I moved your change into #535

haobibo commented 7 years ago

cool~