check_packages in R: avoid attaching namespaces

jupyter / declarativewidgets

[RETIRED] Jupyter Declarative Widget Extension

http://jupyter.org/declarativewidgets/docs.html

Other

120 stars 38 forks source link

check_packages in R: avoid attaching namespaces #550

Closed wjsi closed 7 years ago

wjsi commented 7 years ago

Contributed by @flying-sheep in https://github.com/siyuwj/declarativewidgets/pull/1 :

loading a package should never attach any other package namespaces to the search path. all other library calls should also be removed from this package, and replaced with importFrom directives in NAMESPACE.

poplav commented 7 years ago

I will squash these 7 commits down, but appears https://github.com/jupyter/declarativewidgets/pull/550/commits/a2cf7422c8b63c19eaf458cbed5b2c32797956be is the only change

flying-sheep commented 7 years ago

whoops, sorry for PR-ing against the wrong repo

poplav commented 7 years ago

Closing this in favor of https://github.com/jupyter/declarativewidgets/pull/551. I moved the one commit @flying-sheep had and cleaned up a bit more to remove the library calls.