jupyter / declarativewidgets

[RETIRED] Jupyter Declarative Widget Extension
http://jupyter.org/declarativewidgets/docs.html
Other
120 stars 38 forks source link

dom-bind-behavior bug against Polymer 1.9 #561

Open haobibo opened 7 years ago

haobibo commented 7 years ago

I‘m trying to resolve the dependency hell of bower packages in https://github.com/jupyter-widgets/declarativewidgets/pull/560, but a bug in dom-bind-behavior leads to test fail.

Given that PolymerElements (e.g.: test-fixture) keeps updating, we need either

I'm trying to take the b) approach, and just found a bug in dom-bind-behavior when polymer upgrade from 1.5 to 1.9 in this build, in which the failed test is the urth-core-bind test suit: "should use proper channel data" (cascade of urth-core-bind element).

After a little bit dig, I found the bug is caused by this line of code: https://github.com/jupyter-widgets/declarativewidgets/blob/master/elements/urth-core-bind/dom-bind-behavior.html#L141

Works well with Polymer 1.5 15 Won't render in Polymer 1.9 19