jupyter / docker-stacks

Ready-to-run Docker images containing Jupyter applications
https://jupyter-docker-stacks.readthedocs.io
Other
8.02k stars 2.99k forks source link

Pin min notebook version #2167

Closed mathbunnyru closed 3 weeks ago

mathbunnyru commented 3 weeks ago

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

mathbunnyru commented 3 weeks ago

jupyterlab 4.3.0 has been released, but the new notebook which supports this version hasn't yet.

Unfortunately, previous versions of notebook (<v7) didn't have a version restriction on jupyterlab, so the solver installs jupyterlab 4.3.0 and notebook 6.5.7 (and obviously it doesn't work)

To fix this problem, I decided to pin the minimum notebook version. We might need to keep this pin forever so we don't have the same problem with new releases of jupyterlab.

@krassowski @minrk @bollwyvl do you maybe know a better solution?

mathbunnyru commented 3 weeks ago

Merging this, because currently, our builds are failing. Please let me know, if there is a better solution.