Voila incorporation - Githubissues

jupyter / enhancement-proposals

Enhancement proposals for the Jupyter Ecosystem

https://jupyter.org/enhancement-proposals

BSD 3-Clause "New" or "Revised" License

116 stars 65 forks source link

Voila incorporation #42

Closed SylvainCorlay closed 5 years ago

SylvainCorlay commented 5 years ago

We propose to make Voilà an official Jupyter subproject.

Zsailer commented 5 years ago

To be explicit with my "approval", I both approve the document (reviewed it for typos and think it's ready for merge) and vote in favor of accepting the proposal. 😄 I'm not sure how to best signal those two actions on Github.

betatim commented 5 years ago

Should we use this JEP to test drive the JEP Process? Instead of winging it without a process.

I say test drive because JEP-29 has been merged but is still marked as draft. If the status should be "accepted" then read this as a reminder that there is a process that should be used ;)

SylvainCorlay commented 5 years ago

Thanks @betatim. It does not seem that the new process provides a method to incorporate existing projects as subprojects though. The new jupyter_server proposal is pretty much going through the new process.

takluyver commented 5 years ago

There are two files which look ~identical at a glance. Is that deliberate? :confused:

SylvainCorlay commented 5 years ago

There seems to have been a rebasing issue. Fixing this now.

SylvainCorlay commented 5 years ago

There are two files which look ~identical at a glance. Is that deliberate? confused

There seems to have been a rebasing issue. Fixing this now.

done.

SylvainCorlay commented 5 years ago

Gentle ping @mpacer @ellisonbg @willingc - are you fine with this as it is? CC @jhamrick @Carreau @Ruv7

ellisonbg commented 5 years ago

I approve

Ruv7 commented 5 years ago

Sorry for the delay @SylvainCorlay - I abstain from this vote.

SylvainCorlay commented 5 years ago

To summarize the results of the votes:

We got 11 approvals from SC members here (Brian, Fernando, Paul, Min, Peter, Afshin, Jason, Thomas, Kyle, Damian, Steve), 1 explicit abstension (Ana). 2 more approvals by members of the steering council on the SC mailing list (M, Carol). Matthias and Jess have not voted on this.
Quoting the process for "proposal for incorporation": upon proposal, allow a week for potential objections (explicit agreement welcome, of course). If no objections, treat silence as agreement. So it seems that we got an approval here.

Also, many thanks to @Zsailer, @bollwyvl, @lheagy, @jtpio, @martinrenou for reviewing the JEP PR and approving the proposal!

jasongrout commented 5 years ago

Sounds like we've passed with flying colors. Thanks!