search

jupyter / governance

The governance process and model for Project Jupyter
https://jupyter.org/governance/index.html
Creative Commons Zero v1.0 Universal
82 stars 71 forks source link

Fix broken link to CoC enforcement #199

Closed JasonWeill closed 10 months ago

JasonWeill commented 10 months ago

Fixes a broken link from governance/conduct/code_of_conduct.md to …/enforcement.md, as first observed by @adriens in https://github.com/jupyterlab/jupyter-ai/pull/577#issuecomment-1889973884 — thanks!

krassowski commented 10 months ago

I don't believe the link is broken when deployed on https://jupyter.org/governance/conduct/code_of_conduct.html and would worry that it could possibly break with this change. It is just not meant to be used on GitHub - see that all other links are without .md

JasonWeill commented 10 months ago

I did find two links that already ended in .md:

This one is properly transformed to .html in the published docs: https://github.com/jupyter/governance/blob/bbb9ff9ec62a49afcc2e385720f57e68a7e23b80/conduct/reporting_online.md?plain=1#L7

This one is not; "standard procedure" renders as regular text, not as a link: https://github.com/jupyter/governance/blob/bbb9ff9ec62a49afcc2e385720f57e68a7e23b80/conduct/reporting_online.md?plain=1#L53

JasonWeill commented 10 months ago

Fixed the latter link above to link to a page; linking to a named anchor doesn't seem to be supported. Tested locally.

JasonWeill commented 10 months ago

Thank you @willingc ! I don't have write access to this repository. Would you be able to merge this change in, please?