jupyter / help

:sparkles: Need some help or have some questions? Please visit our Discourse page.
https://discourse.jupyter.org
291 stars 97 forks source link

Converting a Notebook to slides with dark themes don't always work well #247

Open baco opened 6 years ago

baco commented 6 years ago

I am using the conversion commands:

When converting notebooks to the Reveal.js dark themes sometimes the background doesn't change to dark and some fonts do change to bright colors making them invisible (header fonts in theme black, blood, night, moon), and sometimes the conversion takes the dark background but some fonts remain in black and get confused with the new background (normal fonts in theme league).

In some cases code tagged text get both a dark font and a dark background, for instance in theme blood.

The Jupyter input-area never uses some of the dark themes for code provided in Revel.js, for example Monokai.

takluyver commented 6 years ago

cc @damianavila

damianavila commented 6 years ago

Yes, dark themes need further customization to be able to use them. You can probably add css adjustment to make it look OK, but trying to support dark themes on the default experience is something we probably need to check in terms of cost vs. rewards benefit, because it is probably not trivial to make it right and I am no sure how many are actually using dark themes.