Review color of highlights

jupyter / jupyter-alabaster-theme

BSD 3-Clause "New" or "Revised" License

2 stars 15 forks source link

Review color of highlights #57

Closed willingc closed 7 years ago

willingc commented 7 years ago

I've built the JupyterHub docs with this theme and deployed on my test-jupyterhub RTD instance:

http://test-jupyterhub.readthedocs.io/en/doc-theme-jala/api/app.html

I made no changes other than enabling the jupyter-alabaster-theme. Nice job!

There's a lot of "red" highlighting of links. I wonder if we should look at a different color since red evokes warning to me. Maybe blue?

cc/ @cameronoelsen @charnpreetsingh @ellisonbg @minrk

minrk commented 7 years ago

for generic literals like that, I would think that using the default text color (dark grey / black) makes the most sense, rather than any color.

charnpreetsingh commented 7 years ago

It looks like the color is coming from Bootstrap's code.less. I'll have a fix later today. Interestingly, the sphinx_rtd_theme does this behavior as well.

Ex: https://jupyterlab-tutorial.readthedocs.io/en/latest/adding_content.html

minrk commented 7 years ago

FWIW, this CSS makes it look a bit more low-key:

code {
  /* disable red, padded code style from bootstrap */
  background-color: transparent;
  padding: 0px;
  color: inherit;
}