search

jupyter / jupyter-js-notebook

JupyterLab notebook
BSD 3-Clause "New" or "Revised" License
46 stars 17 forks source link

Make findKernel and selectKernel independent of notebook. #172

Closed afshin closed 8 years ago

afshin commented 8 years ago

In this PR:

  1. Make selectKernel and findKernel work independently of a notebook model.
  2. Update example to use new signatures of selectKernel and findKernel.
  3. Bugfix: CodeMirror needed to be imported in notebook model file.
blink1073 commented 8 years ago

Okay, yes, CodeMirror does have to be there, and I'll have to update the tests to use karma. Please just comment out the test runners in scripts/travis_script.sh and we'll move forward.

blink1073 commented 8 years ago

Thanks!