search

jupyter / jupyter-js-notebook

JupyterLab notebook
BSD 3-Clause "New" or "Revised" License
46 stars 18 forks source link

Code cells in `command` mode should be rendered #200

Closed blink1073 closed 8 years ago

blink1073 commented 8 years ago

CodeMirror measures on window resizes, so having as few around as possible is good.

blink1073 commented 8 years ago

See https://codemirror.net/demo/runmode.html for an example - generates innerHTML on a node:

import "codemirror/addon/runmode/runmode"
CodeMirror.runMode(myText, myMode, myNode);
blink1073 commented 8 years ago

This should not be done automatically by the code cell, but available as render/unrender methods that can be used by a single-user notebook or a console, for example.

afshin commented 8 years ago

👍

I agree. In the console, this is a no-brainer optimization.

blink1073 commented 8 years ago

Moved to https://github.com/jupyter/jupyterlab/issues/15