jupyter / jupyter-js-notebook

JupyterLab notebook
BSD 3-Clause "New" or "Revised" License
46 stars 18 forks source link

StringSearch should be removed from completion model #220

Open afshin opened 8 years ago

afshin commented 8 years ago

The StringSearch module in completion/model.ts is a direct copy of the search algorithm in phosphor-core. Once phosphor-core is integrated with jupyter-js-notebook and the old phosphor libs are upgraded, this namespace should be removed in favor of the library version.

cf. #170

cc: @blink1073 @sccolbert @jasongrout