jupyter / jupyter-sphinx

Sphinx extension for rendering of Jupyter interactive widgets.
https://jupyter-sphinx.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
186 stars 65 forks source link

use nbconvert to write scripts #160

Closed akhmerov closed 4 years ago

akhmerov commented 4 years ago

Compared to the current implementation

@chrisjsewell :point_up: I think this supersedes #159

I think we could lean more on the nbconvert API, but this seems like a direct incremental improvement over what we have now.

chrisjsewell commented 4 years ago

Thanks @akhmerov, see the code comment

chrisjsewell commented 4 years ago

and looks like issues with the logger 😬

akhmerov commented 4 years ago

and looks like issues with the logger :grimacing:

https://github.com/ipython/traitlets/issues/606 :tired_face:

I'll think what to do about those.

chrisjsewell commented 4 years ago

FYI, you may want to try using tox (see https://github.com/executablebooks/MyST-NB/blob/master/tox.ini), which I've found recently makes it super easy to run these tests locally, without the need to set up a development environment

akhmerov commented 4 years ago

FYI, you may want to try using tox (see https://github.com/executablebooks/MyST-NB/blob/master/tox.ini), which I've found recently makes it super easy to run these tests locally, without the need to set up a development environment

Sounds good, #161

akhmerov commented 4 years ago

Still remaining: tests, including coconut kernel, although I gotta avoid making this a dependency.