Closed akhmerov closed 4 years ago
Thanks @akhmerov, see the code comment
and looks like issues with the logger 😬
and looks like issues with the logger :grimacing:
https://github.com/ipython/traitlets/issues/606 :tired_face:
I'll think what to do about those.
FYI, you may want to try using tox (see https://github.com/executablebooks/MyST-NB/blob/master/tox.ini), which I've found recently makes it super easy to run these tests locally, without the need to set up a development environment
FYI, you may want to try using tox (see https://github.com/executablebooks/MyST-NB/blob/master/tox.ini), which I've found recently makes it super easy to run these tests locally, without the need to set up a development environment
Sounds good, #161
Still remaining: tests, including coconut kernel, although I gotta avoid making this a dependency.
Compared to the current implementation
@chrisjsewell :point_up: I think this supersedes #159
I think we could lean more on the nbconvert API, but this seems like a direct incremental improvement over what we have now.