search

jupyter / jupyter-sphinx

Sphinx extension for rendering of Jupyter interactive widgets.
https://jupyter-sphinx.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
186 stars 65 forks source link

No jupyter execution when not necessary #231

Open kwankyu opened 1 year ago

kwankyu commented 1 year ago

If all jupyter code blocks has :hide-output: flag, then there's no need to run jupyter notebooks. This case arises when all code blocks are supposed to be run by thebe.

The branch of this PR speeds up processing rst files by bypassing jupyter notebook execution in such cases.

12rambau commented 8 months ago

Hi all I'm a new maintainer of the package and I'll try my best to review your PR. I really like the idea so let's make it ready for the next release !

Are you still willing to work on this PR or should I merge it to a feature branch ?

kwankyu commented 8 months ago

Congrats and thanks!

I will revise and rebase this PR to the current base branch soon.

kwankyu commented 8 months ago

OK. This PR is good to go. Please review.

kwankyu commented 8 months ago

I was not aware of the test failure. Fixed now.

12rambau commented 7 months ago

The test PR was because of concurrent PR. Apologies for the slow-paced review, I'm swamped with other duties at work.