search

jupyter / jupyter.github.io

Project Jupyter's home on the World Wide Web
https://jupyter.org
BSD 3-Clause "New" or "Revised" License
178 stars 180 forks source link

fix lighthouse, closes #745 #749

Closed ivanov closed 9 months ago

ivanov commented 9 months ago

we were using https://github.com/treosh/lighthouse-ci-action v8 before, this moves it up to v10.

:crossed_fingers:

ivanov commented 9 months ago

Well, we got somewhere - now at least we get a generated report, and the problem is that our best practices aren't good enough (score of 92 which is < 95). I'll try to install https://github.com/e73b025/jekyll-content-security-policy-generator into jekyll to see if that gets the score raised, but if it doesn't, will just fall back to lowering the threshold here so we can move forward.

ivanov commented 9 months ago

yeah, looks like that CSP generator made more problems than it fixed, so we learn, once again, that the key to happiness, is lowered expectations. :D

ivanov commented 9 months ago

:heavy_check_mark: All tests passed!